New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 697 load hangout #703

Merged
merged 16 commits into from Nov 13, 2017

Conversation

Projects
None yet
2 participants
@railsstudent
Collaborator

railsstudent commented Nov 7, 2017

Fixes #697.

  1. Change "click to load hangout" from anchor to button by applying classes btn and btn-primary to render white text on blue background
  2. Apply bootstrap alert alert-info classes to make "If you are seeing blank..." text to information alert
  3. Change the color of "End hangout manually" button to #AD4545. The color can be adjusted because less red is subjective to the person who sees it.

24_7_hangout
hangout

@lpatmo lpatmo added the In Review label Nov 7, 2017

@lpatmo

lpatmo approved these changes Nov 13, 2017

W00t. Only small change I made was to style the "Click to load hangout" button in the .btn-cb2 style, so that it matches with the other buttons throughout the site.

@railsstudent Sorry it took me a while to review this, and thank you for the PR!

lpatmo added some commits Nov 13, 2017

@lpatmo lpatmo merged commit cbbd9be into codebuddies:staging Nov 13, 2017

@lpatmo lpatmo added closed and removed In Review labels Nov 13, 2017

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 13, 2017

Collaborator

@lpatmo Thanks Linda, you are the queen of codebuddies

Collaborator

railsstudent commented Nov 13, 2017

@lpatmo Thanks Linda, you are the queen of codebuddies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment