New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 706 consistent height when filter study group #710

Merged
merged 13 commits into from Nov 11, 2017

Conversation

Projects
None yet
2 participants
@railsstudent
Collaborator

railsstudent commented Nov 11, 2017

Fixes 706.

Fix height is not applied to study group when they are filtered by search input.
It is because study group card is missing card CSS class in study group search result template. When card css class is added to the card element, the height is fixed at 130px and each row can fit exactly 3 card elements.

@lpatmo lpatmo added the In Review label Nov 11, 2017

@lpatmo

lpatmo approved these changes Nov 11, 2017

@lpatmo lpatmo merged commit 1ae40d2 into codebuddies:staging Nov 11, 2017

@lpatmo lpatmo added closed and removed In Review labels Nov 11, 2017

@railsstudent railsstudent deleted the railsstudent:issue-706-consistant-height-when-filter-study-group branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment