New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 720 tweet 280 characters #724

Merged
merged 17 commits into from Nov 21, 2017

Conversation

Projects
None yet
3 participants
@railsstudent
Collaborator

railsstudent commented Nov 19, 2017

Fixes #720.

Tweet is sent when new learning is posted or new hangout is scheduled.
On the front-end, increase the character from 140 - 280 in study group learnt and learning status

In the backend, increase truncate count in tweet learning and tweet hangout.
For learning tweet, 250 characters are retained for learning status.
For hangout tweet, 160 characters are retained for hangout goal

hangout_learnt
learning_status

@lpatmo lpatmo added the In Review label Nov 19, 2017

@nalbina

This comment has been minimized.

Show comment
Hide comment
@nalbina

nalbina Nov 19, 2017

Collaborator

Looks good from the technical side! I am trying to get it to run locally, but if that works, it should be good to merge @linda @railsstudent

Collaborator

nalbina commented Nov 19, 2017

Looks good from the technical side! I am trying to get it to run locally, but if that works, it should be good to merge @linda @railsstudent

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 19, 2017

Collaborator

tweet is disabled in dev environment. need to turn on a flag in setting file to test sending tweets to codebuddies.org

Collaborator

railsstudent commented Nov 19, 2017

tweet is disabled in dev environment. need to turn on a flag in setting file to test sending tweets to codebuddies.org

@nalbina

This comment has been minimized.

Show comment
Hide comment
@nalbina

nalbina Nov 19, 2017

Collaborator

I feels a bit weird that the I'm working on is still limited to 140 whereas the today I learned has 280 characters. I know this is linked to what is sent to Twitter or not. but maybe we could align both?

Collaborator

nalbina commented Nov 19, 2017

I feels a bit weird that the I'm working on is still limited to 140 whereas the today I learned has 280 characters. I know this is linked to what is sent to Twitter or not. but maybe we could align both?

@nalbina

This comment has been minimized.

Show comment
Hide comment
@nalbina

nalbina Nov 19, 2017

Collaborator

Which flag do I need to change? @railsstudent

Collaborator

nalbina commented Nov 19, 2017

Which flag do I need to change? @railsstudent

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 19, 2017

Collaborator

isModeProduction from false to true

Collaborator

railsstudent commented Nov 19, 2017

isModeProduction from false to true

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 19, 2017

Collaborator

the i am working on/ i learnt will be removed in hangouts redesign, i would not bother to do further changes

Collaborator

railsstudent commented Nov 19, 2017

the i am working on/ i learnt will be removed in hangouts redesign, i would not bother to do further changes

@nalbina

This comment has been minimized.

Show comment
Hide comment
@nalbina

nalbina Nov 19, 2017

Collaborator

Tweets don't seem to turn up. :/ Possible linked to authentication. @lpatmo can you have a look? @distalx

Collaborator

nalbina commented Nov 19, 2017

Tweets don't seem to turn up. :/ Possible linked to authentication. @lpatmo can you have a look? @distalx

@nalbina

tweets is an auth problem with the dev environment creds which is outside the scope of this pr. good work @railsstudent

LGTM.

@nalbina nalbina merged commit 31191c0 into codebuddies:staging Nov 21, 2017

@lpatmo lpatmo added closed and removed In Review labels Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment