New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 732 study group prompt login #736

Merged
merged 9 commits into from Nov 24, 2017

Conversation

Projects
None yet
3 participants
@railsstudent
Collaborator

railsstudent commented Nov 22, 2017

Fixes #732.

If user is not login, reuse the Sign in with Slack dialog in layout.html.

@lpatmo lpatmo added the In Review label Nov 22, 2017

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 23, 2017

Collaborator

@distalx if button has no id, the CSS styling of create study group will not be applied. Therefore, I introduce a btn-createGroup-NotLoggedIn class and apply the same styling.

Collaborator

railsstudent commented Nov 23, 2017

@distalx if button has no id, the CSS styling of create study group will not be applied. Therefore, I introduce a btn-createGroup-NotLoggedIn class and apply the same styling.

railsstudent added some commits Nov 23, 2017

Fix copy and paste error.
btn-createGroup-notLoggedIn pasted in wrong place
@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Nov 23, 2017

Collaborator

@distalx Fixed. Please kindly review. Thanks.

Collaborator

railsstudent commented Nov 23, 2017

@distalx Fixed. Please kindly review. Thanks.

@distalx

LGTM!

@distalx distalx merged commit 7f10f33 into codebuddies:staging Nov 24, 2017

@lpatmo lpatmo added closed and removed In Review labels Nov 24, 2017

@distalx

This comment has been minimized.

Show comment
Hide comment
@distalx

distalx Nov 24, 2017

Collaborator

@railsstudent Thanks for the PR!

Collaborator

distalx commented Nov 24, 2017

@railsstudent Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment