New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 753 fallback image #756

Merged
merged 13 commits into from Dec 31, 2017

Conversation

Projects
None yet
2 participants
@railsstudent
Collaborator

railsstudent commented Dec 31, 2017

Fixes #753

Show fallback image if image url of contributor is broken.
Tested on firefox, chromium and chrome
fallback_image

@lpatmo lpatmo added the In Review label Dec 31, 2017

@lpatmo

lpatmo approved these changes Dec 31, 2017

@lpatmo lpatmo merged commit df485b3 into codebuddies:staging Dec 31, 2017

@lpatmo lpatmo added closed and removed In Review labels Dec 31, 2017

lpatmo added a commit that referenced this pull request Jan 1, 2018

New Year's Eve release (#758)
* Issue 691 hangout participant count (#719)

* fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694)

* Issue-691. Show number of participants in 24/7 hangout




Issue-691. show number of hangout participants in all study group and my study group pages


issue-691.  Only decrement participant count when the logged in user joins the hangout room


Issue-691 Decrement participant count when value is positive

* Remove unique index comment

* fix 'participants_count' of undefined console err

* Get rid of session variable

* Move server-side logic to new files

* Enable seed data

* minor improvements

* Show laptop icon when people join 24/7 hangout

* Fix account deletion. (#745)

* fix typo

* Schedule hangout default studygroup name (#743)

* Default study group name 

when schedule a hangout in single study group
duplicate hangout in single study group

* Default study group name 

value is not displayed in dropdown input area unless trigger('change') is fired

* Fixed error

* Issue 667 create slack page (#744)

* Create new Slack page

* Add helpful links

* Minor content edits!

Note: I removed the slackin plugin in favor of a direct link because I noticed some positioning issues with the form that appears after a user clicks on the plugin; it's sometimes out of reach, and will make the user think that nothing happened.

* Show study group name in disabled input box in modal (#748)

* Refactoring 1 (#752)

* fix for bug 690: admins should be able to access 24/7 hangout (#693) (#694)

* refactor (routes) remove subs from router level

* refactor (hangout_logged_out) make use of new syntax

* refactor (hangouts) - remove dead code, restructure single hangout view

* Add 'add to google calendar' button that opens up link with event details from hangout, including meet.jit.si location (#755)

* Display fallback image if image url of contributor is broken (#756)

* Issue 547 redesign of /hangouts page (#757)

* redesigned header area

* hangouts area now uses flexbox + big redesign of cards area

* adjust column display on profile page

* completed hangout cards do not need to be very tall; also, hide meta content on hover

* add popover descriptions for silent/collaboration/teaching icon keys

* grammar correction

* update hangout-faq a bit more, and give it its own route

* capitalization fixes

* adjust hover behavior of btn-block

* fix up hangout cards in study groups

* update faq content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment