New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor about page v2 #760

Merged
merged 34 commits into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@railsstudent
Collaborator

railsstudent commented Jan 6, 2018

Externalize details of contributors in private/about.json and read the data from it when rendering the images and popups in about.html.

When new contributors wants to add themselves to about page, they can append JSON object of personal details in code-contributors array.

The html code in title attribute in original design is errone hone with all these angle brackets

distalx and others added some commits Nov 8, 2017

@railsstudent railsstudent requested a review from lpatmo Jan 6, 2018

@railsstudent railsstudent requested a review from distalx Jan 6, 2018

@lpatmo lpatmo added the In Review label Jan 6, 2018

@lpatmo

lpatmo approved these changes Jan 6, 2018

Looks great! @railsstudent Could I move <img src="https://avatars1.githubusercontent.com/u/1159649?v=4&s=460" class="img-circle" alt="Connie Leung"/> up to the core contributors section? Will link to your twitter and github.

@railsstudent

This comment has been minimized.

Show comment
Hide comment
@railsstudent

railsstudent Jan 7, 2018

Collaborator

@lpatmo Yes, you can move my image to core contributor session.
My slack handler name is @connie
twitter is con_leung
github is railsstudent

Thanks.

Collaborator

railsstudent commented Jan 7, 2018

@lpatmo Yes, you can move my image to core contributor session.
My slack handler name is @connie
twitter is con_leung
github is railsstudent

Thanks.

@distalx

Thanks for the PR! Here are some suggestions I hope you'll find helpful.

Show outdated Hide outdated private/about.json Outdated

railsstudent and others added some commits Jan 11, 2018

Move json file to client side
Refactor about page
Update contributors.json
@railsstudent I added a short placeholder-ish description for you, but please feel free to edit!
Merge branch 'refactor-about-page-v2' of git://github.com/railsstuden…
…t/codebuddies into railsstudent-refactor-about-page-v2

@distalx distalx merged commit 386c1c2 into codebuddies:staging Jan 12, 2018

@lpatmo lpatmo added closed and removed In Review labels Jan 12, 2018

@distalx

This comment has been minimized.

Show comment
Hide comment
@distalx

distalx Jan 12, 2018

Collaborator

@railsstudent , Thanks for the pull request.

Collaborator

distalx commented Jan 12, 2018

@railsstudent , Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment