Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon in TOTP apps #140

Closed
sargola opened this issue Aug 27, 2018 · 4 comments
Closed

Icon in TOTP apps #140

sargola opened this issue Aug 27, 2018 · 4 comments
Labels

Comments

@sargola
Copy link

sargola commented Aug 27, 2018

Type of issue

[ ] Bug
[ ] Question (e.g. about handling/usage)
[x] Request for new feature/improvement

Expected Behavior

I would like to be able to specify an image for the apps that scan the QRCode and calculate the codes. LastPass has its own icon and Microsoft accounts even have their avatar in it.

Current Behavior

I am not able to so this as far as I can see.

  • Version used: 1.3.3
  • Compiled from source or NuGet package?: nuget
  • Payload/Encoded text:
  • Used payload generator: OneTimePassword
  • Used ECC-level: Q
  • Used renderer class: QRCodeData
  • Environment (.NET 3.5, .NET 4.X, .NETCore, ...): .net 4.x
    -->
@sargola
Copy link
Author

sargola commented Aug 27, 2018

one remark: I found the overlaod of qrCode.GetGraphic(...) which takes a Bitmap but it just renders the image in the center, the qrcode is still scannable but does not show an icon in the microsoft or google authenticator app. Thanks for your support!

@sargola
Copy link
Author

sargola commented Sep 12, 2018

heya, any news on this?
cheers,
Michi

@codebude
Copy link
Owner

Hi @sargola ,

I'm not sure if I got your request, but are you asking for a visible icon on the QR code image or are you asking for a image, which shows up in the authenticator apps when the QR code is scanned?

If first, then you should use the GetGraphic overload which takes an Bitmap. The one you already found. If you want the second, then I have to disappoint you. Im pretty sure LastPass and Microsoft doesn't save any image information in the QR codes, but the authenticator apps display the images based on the issuer information from the QR codes. I think, when the authenticator app scans a code from Microsoft it has some logic to show Microsoft's logo. So if you want your logo to show up, then you should get in contact with the different authenticator app providers.

For example I decoded an TOTP qr code from last pass.
lpass

Its content looks like this:

otpauth://totp/LogMeIn%20Accounts%3A%20scott%40lastpass.com?secret=PO25V3FOQZYZDIKVUHV2EJXLFC4V3LSR&issuer=LastPass&lmirequesttoken=01_W1FmfRVcinNiLYUvnqvhpbms9qXIswP8r8fHH3vO9CoUI7RsZ8oFb3RnT2JPaZ2A&lmiversion=1

This url clearly hasn't any image information in it. If your authenticator app shows a lastpass logo nevertheless, then it's part of the authenticator's source code.

@sargola
Copy link
Author

sargola commented Oct 10, 2018 via email

@codebude codebude reopened this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants