Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2017 - Codemaid thinks files opened from "lightweight" projects are external #389

Open
michaelaird opened this issue Jan 19, 2017 · 5 comments

Comments

@michaelaird
Copy link

Environment

  • Visual Studio version: 2017 RC
  • CodeMaid version: 10.2.7
  • Code language: C#

Description

When the solution is opened in "lightweight mode" not all the projects are loaded. If you navigate into a file in a project that is not fully loaded (ie. go to definition), when you tell CodeMaid to clean it, CodeMaid thinks the file is external.

Steps to recreate

  1. Open a solution in "lightweight mode"
  2. Navigate into a file in a project that is not fully loaded (use go to definition, etc)
  3. Clean the file

Current behavior

CodeMaid shows the dialog that the file is external and some cleanup actions may not be available.

Expected behavior

Ideally, it would prompt to load the project or do so silently in the background before cleaning.

@codecadwallader
Copy link
Owner

Thanks for the suggestion. Have you seen any code samples for how to detect that state and/or request a project load?

@willl
Copy link

willl commented May 31, 2017

@codecadwallader Perhaps some of this documentation on Lightweight solution loading from the VS2017 SDK would help
https://docs.microsoft.com/en-us/visualstudio/extensibility/lightweight-solution-load-extension-impact

@codecadwallader
Copy link
Owner

Thanks for the documentation. I did discuss LSL mode with someone from Microsoft a couple months back as they were starting to push it harder. One of the main sticking points is that LSL mode is really only compatible with the newer Roslyn APIs, not the EnvDTE APIs that CodeMaid has been based on since VS2005 days. We know that a Roslyn rewrite (see #251) is inevitable for long term support of CodeMaid going forwards, but its a very large undertaking.

@michaelaird
Copy link
Author

michaelaird commented May 31, 2017 via email

@codecadwallader
Copy link
Owner

We are absolutely open source and would gladly welcome any contributions if you have time to experiment with it. http://www.codemaid.net/contribute/ has some helpful getting started information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants