Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented RadialProgressBar in SpadeToolbar #477

Merged
merged 5 commits into from Aug 31, 2017

Conversation

@Jammer77
Copy link
Contributor

@Jammer77 Jammer77 commented Aug 28, 2017

No description provided.

@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 28, 2017

How to delete TEST commit?

@codecadwallader
Copy link
Owner

@codecadwallader codecadwallader commented Aug 28, 2017

I haven't used them, but rebase and cherry-pick are a couple commands I've heard in that space if you want to investigate them. A simpler approach may be to make another commit that undoes whatever changes are in your test commit. The pull request will then reflect the canceled out changes.

@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 28, 2017

Are you happy, is it a cool control?

@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 28, 2017

Can you merge? Or you need something?

@codecadwallader
Copy link
Owner

@codecadwallader codecadwallader commented Aug 29, 2017

I appreciate your enthusiasm. It does look like it will be cool. I haven't pulled it down locally yet to test it, but a couple items that I'd appreciate having resolved:

  1. The TEST commit you put in with unwanted code changes needs to be cleaned up. See comments above about a couple possible approaches.
  2. There is a mismatch between a WidthConverter file with a CenterConverter class in it. Since this converter is only dividing by two, lets please call both the file and the class a HalfConverter so it may be clearer to others.
@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 29, 2017

Ok

@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 29, 2017

Now you can merge :)

@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Aug 29, 2017

🥇

@codecadwallader
Copy link
Owner

@codecadwallader codecadwallader commented Aug 31, 2017

That looks awesome!! Thanks so much for doing that! Merging now. :D

@codecadwallader codecadwallader merged commit 5344dde into codecadwallader:master Aug 31, 2017
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@codecadwallader codecadwallader added this to the v10.5 milestone Aug 31, 2017
@Jammer77
Copy link
Contributor Author

@Jammer77 Jammer77 commented Sep 1, 2017

Thanks for your great tool!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.