Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Make all features switchable #525
Hi, I complete this feature #296 finally. I made lots of changes, for simplifying your review, I give you a few explanations here.
All unit tests passed, but I'm not able to run the integration tests, I've selected the IntegrationTests.testsettings file as doc. I tried both VS 15.6 preview 3.0 and 15.5.5, if you know the reason, please teach me.
Please have it reviewed and feel free to let me know if you have any question or concern. As I'm not good at English, I don't write too many comments in code, if this is required, I'll try to add them later.
This PR also completes the #335, which you planned for v10.5.
Thank you again for your hard work on this, I really appreciate it and I think the users will really appreciate it as well. I have a number of questions and suggestions, please let me know if there's anything I can help clarify or we can figure out together!
Also, as a heads up there is another pull request for localization going on (i.e. to support Chinese menus/labels/etc.). I think there will be a fair amount of conflict between the changes on this pull request and that one so that may be something we have to work through later (that one is further along).
Thanks for the updates, those all look good! I don't think I have any further questions right now. I'll need to play around/test it some more before I can merge, but looking great!
One thing I was wondering is if someone disables a feature at their user settings level, but the solution they're loading has configuration options expecting it to be present.. what happens? I think since the feature isn't loaded it would simply fail to execute, and that's probably fine. I think when you explicitly turned on features inside CodeMaid's own solution settings was an example of overriding features to be enabled at the solution level (ignoring user preferences). Does that sound right and do you have any other thoughts around that?
This can be tested (by anyone interested) in our CI build here: http://vsixgallery.com/extension/4c82e17d-927e-42d2-8460-b473ac7df316/
added a commit
this pull request
Mar 24, 2018
@heku FYI: For the order of the features I came up with a third option where we would organize the commands in the same way they are organized on the main menu. I think this makes the most sense and is more consistent, so I went ahead and made this change. Please let me know if you have any different thoughts!
@codecadwallader Thank you, most make sense to me, except the Cleanup Selected Code and Cleanup All Code are placed in different group, this might be a little confused, in my opinion, it's better to always put these two items together. Maybe just move the Cleanup Selected Code up to the Cleaning group, or move the Cleanup All Code down to the Solution Explorer group. How do you think? Feel free to disagree my comment if it doesn't make sense.