Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated grabbers #2381

Merged
merged 3 commits into from May 5, 2020
Merged

updated grabbers #2381

merged 3 commits into from May 5, 2020

Conversation

DavertMik
Copy link
Contributor

Motivation/Description of the PR

Updated Playwright grab functions to match new spec

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@github-actions
Copy link

github-actions bot commented May 5, 2020

🌀 Tests overview by Testomatio

Found 861 mocha tests in 75 files

🗑️ Removed 4 tests

- Playwright: #grabHTMLFrom: should grab inner html from an element using xpath query
- Playwright: #grabHTMLFrom: should grab inner html from an element using id query
- Playwright: #grabHTMLFrom: should grab inner html from multiple elements
- Playwright: #grabHTMLFrom: should grab inner html from within an iframe
⚠️ List all skipped test (1)
📎 List all suites (63)

@DavertMik DavertMik merged commit f8537c8 into codeceptjs-v3.0 May 5, 2020
@DavertMik DavertMik deleted the playwright-compat branch May 5, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant