Issue 2434 (handle .indexOf error) #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobenguyent
approved these changes
Jun 11, 2020
Vorobeyko
previously approved these changes
Jun 15, 2020
Vorobeyko
dismissed
their stale review
@Georgegriff Tests were failed two times. Can you fix them ?
|
I'm not sure how I could have broken those tests |
DavertMik
approved these changes
Jun 18, 2020
Vorobeyko
added a commit
that referenced
this pull request
Jun 19, 2020
* updated docs * release 2.6.5 * Fix valid data output (w3) (#2399) * add alt for image UI page (fix w3 validator) (#2403) * docs: fix typo in commands.md (#2405) * remove unnecessary select placeholder from basics.md (#2407) * fix display combination in changelog (#2409) * add description to images (#2412) * Fix android native locator support for appium helper (#2429) * Update mobile.md * Fix android native locator support for appium helper * update the expected result for windows platform especially the absolute path case because in windows, path.resolve returns driver letter * chore: jsdoc color param optional in `I.say` (#2443) * update github links after repository migration (#2447) * Fixed waitNumberOfVisibleElements for Webdriver (#2418) * fix waitNumberOfVisibleElements waitNumberOfVisibleElements returns false everytime as it does not filter the visible element count * fix waitNumberOfVisibleElements waitNumberOfVisibleElements returns false everytime as it does not filter for visible elements * Issue 2434 (handle .indexOf error) (#2436) * Makes suggested changes to have Chromium install * fixes #2434 * fix playwright too Co-authored-by: George Griffiths <george.griffiths@ibm.com> * Puppeteer handle page error (#2435) * Makes suggested changes to have Chromium install * handle page crash * handle undefined page * dont open new tab on crash * remove old try catch Co-authored-by: George Griffiths <george.griffiths@ibm.com> * Feat: Skip feature (#2427) * Makes suggested changes to have Chromium install * feat: implement skip of features * Add unit tests, docs and type defs * Apply suggestions from code review Co-authored-by: George Griffiths <george.griffiths@ibm.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com> * Release 2.6.6 (#2450) * updated docs * fixed tests & updated linter * updated changelog * fixed mocks Co-authored-by: Davert <davert.ua@gmail.com> Co-authored-by: Mykhailo Bodnarchuk <mykhailo.bodnarchuk@Mykhailos-MacBook-Pro.local> Co-authored-by: Ihor Sychevskyi <26163841+Arhell@users.noreply.github.com> Co-authored-by: Aleksei Gurianov <gurianov@gmail.com> Co-authored-by: Tanakiat Srisaranyakul <tanakiats@hotmail.com> Co-authored-by: Bartosz Wojtkowiak <bartosz@wojtkowiak.it> Co-authored-by: Vijay Venkatesh <ilangovan.vijay@gmail.com> Co-authored-by: George Griffiths <georgegriffiths@live.com> Co-authored-by: George Griffiths <george.griffiths@ibm.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com>
Vorobeyko
added a commit
that referenced
this pull request
Aug 20, 2020
* updated docs * release 2.6.5 * Fix valid data output (w3) (#2399) * add alt for image UI page (fix w3 validator) (#2403) * docs: fix typo in commands.md (#2405) * remove unnecessary select placeholder from basics.md (#2407) * fix display combination in changelog (#2409) * add description to images (#2412) * Fix android native locator support for appium helper (#2429) * Update mobile.md * Fix android native locator support for appium helper * update the expected result for windows platform especially the absolute path case because in windows, path.resolve returns driver letter * chore: jsdoc color param optional in `I.say` (#2443) * update github links after repository migration (#2447) * Fixed waitNumberOfVisibleElements for Webdriver (#2418) * fix waitNumberOfVisibleElements waitNumberOfVisibleElements returns false everytime as it does not filter the visible element count * fix waitNumberOfVisibleElements waitNumberOfVisibleElements returns false everytime as it does not filter for visible elements * Issue 2434 (handle .indexOf error) (#2436) * Makes suggested changes to have Chromium install * fixes #2434 * fix playwright too Co-authored-by: George Griffiths <george.griffiths@ibm.com> * Puppeteer handle page error (#2435) * Makes suggested changes to have Chromium install * handle page crash * handle undefined page * dont open new tab on crash * remove old try catch Co-authored-by: George Griffiths <george.griffiths@ibm.com> * Feat: Skip feature (#2427) * Makes suggested changes to have Chromium install * feat: implement skip of features * Add unit tests, docs and type defs * Apply suggestions from code review Co-authored-by: George Griffiths <george.griffiths@ibm.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com> * Release 2.6.6 (#2450) * updated docs * fixed tests & updated linter * updated changelog * fixed mocks * Honor reporter configuration in mocha (#2465) * Update compilerOptions.target to es2017 (#2484) This resolves (#2483), since async and await are no long transpiled to ES generators * Fix playwright set cookie (#2491) * Fix setCookie for Playwright helper * fix lint issue Co-authored-by: Ben Barker <benbarker@workfront.com> * Add documentation changes for check-tests (#2502) * fix markdown video links (#2489) * Update pageobjects.md (#2497) * update plugins page "h" tags for more readable (#2501) * Fix typo in locators docs section (#2503) * Right click issue fix for Webdriver (#2485) * Right click issue fix for Webdriver * moveTo added in rightclick * Native Click used to perform rightclick operation * Added `forceRightClick` method to emulate rightclick event instead of using native events. * Add --invert option for run-workers command (#2504) * add missing REST helper (#2474) * Release 2.6.7 (#2506) * Prepare release-2.6.7 * Apply ESLint fixes. * updated playwright workflow to use official action Co-authored-by: Paul Vincent Beigang <paul.beigang@digistore24.com> Co-authored-by: Davert <davert.ua@gmail.com> * slight updates to changelog * added forceRightClick method * Fix missing screenshots on failure when REST helper is in use (#2513) * Improve error logging (#2512) * getPageTimeout: 30000, (#2516) fix(page-timeouts): method amOnPage freezing, when equal 0. * update to relevant path & some fix (#2515) * Update init.js (#2520) * element screenshot method added (#2521) * Rearranged typeof check to handle null parameter (#2494) * Rearranged typeof check to handle null parameter Error: Cannot read property 'toString' of null typeError: Cannot read property 'toString' of null at G:\CodeceptJS-Test\node_modules\codeceptjs\lib\step.js:115:22 Solution: Rearranged typeof check to handle crash when helper method is called with null parameter. * Update step.js * Update step.js * Prepare 2.6.8 release. (#2514) * Prepare 2.6.8 release. * Prepare 2.6.8 release. Co-authored-by: Paul Vincent Beigang <paul.beigang@digistore24.com> * Fix generate:helper command (#2523) * Release 2.6.8 (#2522) * added docs * added type method * fixed steps test * fixed tests & types * fixed tests & types * fixed tests for type * added type to Protractor * fixed typing via Protractor * removed protractor type * removed protractor type * fixed tests * fixed tests * fixed tests * updated release paths * feat(helper): Clear SessinStorage (#2524) * Fix broken URLs (#2528) * update readme file urls (#2534) * update docs md to relevant path (#2530) * Preserve initial error stack when helper load fail (#2541) * Release 2.6.9 (#2545) * fixed tests Co-authored-by: Davert <davert.ua@gmail.com> Co-authored-by: Mykhailo Bodnarchuk <mykhailo.bodnarchuk@Mykhailos-MacBook-Pro.local> Co-authored-by: Ihor Sychevskyi <26163841+Arhell@users.noreply.github.com> Co-authored-by: Aleksei Gurianov <gurianov@gmail.com> Co-authored-by: Tanakiat Srisaranyakul <tanakiats@hotmail.com> Co-authored-by: Bartosz Wojtkowiak <bartosz@wojtkowiak.it> Co-authored-by: Vijay Venkatesh <ilangovan.vijay@gmail.com> Co-authored-by: George Griffiths <georgegriffiths@live.com> Co-authored-by: George Griffiths <george.griffiths@ibm.com> Co-authored-by: Michael Bodnarchuk <DavertMik@users.noreply.github.com> Co-authored-by: Trinh Pham <9128061+trinhpham@users.noreply.github.com> Co-authored-by: Shan <shanplourde@gmail.com> Co-authored-by: Ben Barker <barker.ben.m@gmail.com> Co-authored-by: Ben Barker <benbarker@workfront.com> Co-authored-by: Koushik Mohan <koushikmohan1996@gmail.com> Co-authored-by: Jesus Vilar <jesus.vilar@gmail.com> Co-authored-by: Marcin S艂owiak <marcin.slowiak.007@gmail.com> Co-authored-by: suniljaiswal01 <45997477+suniljaiswal01@users.noreply.github.com> Co-authored-by: Paul <pbeigang@gmail.com> Co-authored-by: Peter Nguyen Tr <peter.nguyentr@gmail.com> Co-authored-by: Paul Vincent Beigang <paul.beigang@digistore24.com> Co-authored-by: Sitam Jana <43989292+sjana-aj@users.noreply.github.com> Co-authored-by: Leonardo Bazico <leonardobazico@gmail.com> Co-authored-by: Igor Strebezhev <xamgore@users.noreply.github.com> Co-authored-by: Michail Shipov <mshipov@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)