Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the method translation of Chinese #1020

Merged
merged 3 commits into from Apr 12, 2018
Merged

Add the method translation of Chinese #1020

merged 3 commits into from Apr 12, 2018

Conversation

@TechQuery
Copy link
Contributor

@TechQuery TechQuery commented Apr 11, 2018

One question: ISO 639.1 or RFC 4646 should I follow on the language name ?

@DavertMik
Copy link
Contributor

@DavertMik DavertMik commented Apr 12, 2018

One question: ISO 639.1 or RFC 4646 should I follow on the language name ?

Sorry, I have no idea 😟
So choose whatever you like and thanks. That's really awesome!

@TechQuery
Copy link
Contributor Author

@TechQuery TechQuery commented Apr 12, 2018

I chose our customary usage, it's OK to merge it.

@DavertMik
Copy link
Contributor

@DavertMik DavertMik commented Apr 12, 2018

Thanks!

@DavertMik DavertMik merged commit 17d4c32 into codeceptjs:master Apr 12, 2018
4 checks passed
4 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
@TechQuery
Copy link
Contributor Author

@TechQuery TechQuery commented Apr 13, 2018

But the document on official website has not been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants