From ae084e5aae29ea01ea2a7b1a61a9acf5a7a9046d Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Thu, 7 Nov 2024 13:32:26 +0100 Subject: [PATCH 1/3] fix: TestCafe uses chromium as default --- lib/helper/TestCafe.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/helper/TestCafe.js b/lib/helper/TestCafe.js index 86f27bc5b..97f78cd94 100644 --- a/lib/helper/TestCafe.js +++ b/lib/helper/TestCafe.js @@ -44,10 +44,10 @@ const getHtmlSource = (t) => * * `windowSize`: (optional) - set browser window width and height * * `getPageTimeout` (optional, default: '30000') config option to set maximum navigation time in milliseconds. * * `waitForTimeout`: (optional) default wait* timeout in ms. Default: 5000. - * * `browser`: (optional, default: chrome) - See https://devexpress.github.io/testcafe/documentation/using-testcafe/common-concepts/browsers/browser-support.html + * * `browser`: (optional, default: chromium) - See https://devexpress.github.io/testcafe/documentation/using-testcafe/common-concepts/browsers/browser-support.html * * - * #### Example #1: Show chrome browser window + * #### Example #1: Show chromium browser window * * ```js * { @@ -56,7 +56,7 @@ const getHtmlSource = (t) => * url: "http://localhost", * waitForTimeout: 15000, * show: true, - * browser: "chrome" + * browser: "chromium" * } * } * } @@ -108,7 +108,7 @@ class TestCafe extends Helper { this.options = { url: 'http://localhost', show: false, - browser: 'chrome', + browser: 'chromium', restart: true, // TODO Test if restart false works manualStart: false, keepBrowserState: false, @@ -133,7 +133,7 @@ class TestCafe extends Helper { static _config() { return [ { name: 'url', message: 'Base url of site to be tested', default: 'http://localhost' }, - { name: 'browser', message: 'Browser to be used', default: 'chrome' }, + { name: 'browser', message: 'Browser to be used', default: 'chromium' }, { name: 'show', message: 'Show browser window', From d63e6c214f429e03678e6ff09e29b7f04143a917 Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Thu, 7 Nov 2024 13:35:07 +0100 Subject: [PATCH 2/3] Update TestCafe_test.js --- test/helper/TestCafe_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/helper/TestCafe_test.js b/test/helper/TestCafe_test.js index 5481810f2..184c2df33 100644 --- a/test/helper/TestCafe_test.js +++ b/test/helper/TestCafe_test.js @@ -22,7 +22,7 @@ describe('TestCafe', function () { url: siteUrl, windowSize: '1000x700', show: false, - browser: 'chrome', + browser: 'chromium', restart: false, waitForTimeout: 5000, }) From b4ab2dd19de502ca8a30c32a4fb9c9ce1a5c2a94 Mon Sep 17 00:00:00 2001 From: kobenguyent <7845001+kobenguyent@users.noreply.github.com> Date: Thu, 7 Nov 2024 13:40:37 +0100 Subject: [PATCH 3/3] Update TestCafe.js --- lib/helper/TestCafe.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/helper/TestCafe.js b/lib/helper/TestCafe.js index 97f78cd94..86f27bc5b 100644 --- a/lib/helper/TestCafe.js +++ b/lib/helper/TestCafe.js @@ -44,10 +44,10 @@ const getHtmlSource = (t) => * * `windowSize`: (optional) - set browser window width and height * * `getPageTimeout` (optional, default: '30000') config option to set maximum navigation time in milliseconds. * * `waitForTimeout`: (optional) default wait* timeout in ms. Default: 5000. - * * `browser`: (optional, default: chromium) - See https://devexpress.github.io/testcafe/documentation/using-testcafe/common-concepts/browsers/browser-support.html + * * `browser`: (optional, default: chrome) - See https://devexpress.github.io/testcafe/documentation/using-testcafe/common-concepts/browsers/browser-support.html * * - * #### Example #1: Show chromium browser window + * #### Example #1: Show chrome browser window * * ```js * { @@ -56,7 +56,7 @@ const getHtmlSource = (t) => * url: "http://localhost", * waitForTimeout: 15000, * show: true, - * browser: "chromium" + * browser: "chrome" * } * } * } @@ -108,7 +108,7 @@ class TestCafe extends Helper { this.options = { url: 'http://localhost', show: false, - browser: 'chromium', + browser: 'chrome', restart: true, // TODO Test if restart false works manualStart: false, keepBrowserState: false, @@ -133,7 +133,7 @@ class TestCafe extends Helper { static _config() { return [ { name: 'url', message: 'Base url of site to be tested', default: 'http://localhost' }, - { name: 'browser', message: 'Browser to be used', default: 'chromium' }, + { name: 'browser', message: 'Browser to be used', default: 'chrome' }, { name: 'show', message: 'Show browser window',