Appium esm migration #5292
Merged
Appium esm migration #5292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert require() to import statements - Change webdriverio from dynamic require to static import - Import webdriverio as namespace (import * as webdriverio) - Import all dependencies at the top of the file: - ElementNotFound from './errors/ElementNotFound.js' - dontSeeElementError from './errors/ElementAssertion.js' - Remove inline require statements from methods: - dontSeeElement() - seeElement() - waitForVisible() - waitForInvisible() - Use Locator.build() instead of new Locator() for ESM compatibility - Maintain export default Appium at the end - All imports use .js extensions for ESM compliance Verified: - Module loads successfully - No require() statements remaining - Tests run without errors
The test was failing with 'Cannot read properties of undefined (reading "be")' because chai's should assertion style was not initialized. Added chai.should() call after imports to enable should-style assertions throughout the test file. Fixes test: device lock : #seeDeviceIsLocked, #seeDeviceIsUnlocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)