Skip to content

Fix browser hanging during cleanup by not waiting for browser.close() to complete #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

Fix browser hanging during cleanup by not waiting for browser.close() to complete #5319

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8913f8
Initial plan
Copilot Nov 19, 2025
fc96ccc
Fix test hang issue when restart: false by properly mapping to contex…
Copilot Nov 19, 2025
f5682e7
Fix browser close hanging by ensuring all pages and contexts are clos…
Copilot Nov 19, 2025
c91d94c
Don't wait for browser.close() to prevent hanging - fire and forget a…
Copilot Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,6 +1389,7 @@ class Playwright extends Helper {
}
}

// Close browserContext if recordHar is enabled
if (this.options.recordHar && this.browserContext) {
try {
await this.browserContext.close()
Expand All @@ -1398,16 +1399,16 @@ class Playwright extends Helper {
}
this.browserContext = null

// Initiate browser close without waiting for it to complete
// The browser process will be cleaned up when the Node process exits
if (this.browser) {
try {
// Add timeout to prevent browser.close() from hanging indefinitely
await Promise.race([this.browser.close(), new Promise((_, reject) => setTimeout(() => reject(new Error('Browser close timeout')), 5000))])
// Fire and forget - don't wait for close to complete
this.browser.close().catch(() => {
// Silently ignore any errors during async close
})
} catch (e) {
// Ignore errors if browser is already closed or timeout
if (!e.message?.includes('Browser close timeout')) {
// Non-timeout error, can be ignored as well
}
// Force cleanup even on error
// Ignore any synchronous errors
}
}
this.browser = null
Expand Down
Loading