Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Improvements #12

Closed
puneet0191 opened this issue Feb 24, 2019 · 8 comments · Fixed by #31
Closed

Minor Improvements #12

puneet0191 opened this issue Feb 24, 2019 · 8 comments · Fixed by #31

Comments

@puneet0191
Copy link
Member

  • add support for IgnoredBox, with updated documentation

  • add a debug to print the path to file, for printing the URL of the Diff Image in the console.

@prasadgujar
Copy link

@puneet0191 are you working on this issue?
if not let me know I m interested in solving issues.

@puneet0191
Copy link
Member Author

@prasadgujar sure go ahead and help me with the issues, let me know how it goes

@prasadgujar
Copy link

Already started working on this issue. @puneet0191

@manciukass
Copy link

Hi, guys maybe you have any status about this request? Or know a workaround for ignoredBoxes to work :)

@puneet0191
Copy link
Member Author

@manciukass IgnoredBoxes can be used by providing element locator so that the screenshot comparison happens only for that element and ignores the rest of the area on the image.
have you tried using :
seeVisualDiffForElement

@manciukass
Copy link

Yes, I know that, but imagine a page with lots of elements, and let's say i would like to ignore half of the page from the bottom. I would not like to check every element separately. So idea to have possibility to check only some parts (big) of page would be really nice to have :)

@puneet0191
Copy link
Member Author

@manciukass hmm you make sense, let me try to add this request as part of the new release which will be 1.6.0 coming out in some days

@manciukass
Copy link

That would be wonderful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants