This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Use fetch_language to coerce python config #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Code change LGTM. Do you think it's worth adding a test? |
Addresses #136 The changes made in #135 didn't account for configuring the languages with empty hash contents. With YAML parsing, something like ``` languages: python: ``` Gets parsed as `{ "languages" => { "python" => "" } }`, leading to a `NoMethodError` when the Python class attempted to discover the configured Python version. `EngineConfig` already had logic to ensure a language configuration was a hash, so this makes the appropriate coercing method public & uses it from the Python class. (Since the python version key is a Python-only option, the `EngineConfig` class still doesn't seem like the appropriate place for that logic.)
wfleming
force-pushed
the
will/empty-hash-config
branch
from
5a15439 to
19b23f5
Compare
|
Test added @maxjacobson. I'm merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #136
The changes made in #135 didn't account for configuring the languages
with empty hash contents. With YAML parsing, something like
Gets parsed as
{ "languages" => { "python" => "" } }, leading to aNoMethodErrorwhen the Python class attempted to discover theconfigured Python version.
EngineConfigalready had logic to ensure a language configuration wasa hash, so this makes the appropriate coercing method public & uses it
from the Python class. (Since the Python version key is a Python-only
option, the
EngineConfigclass still doesn't seem like the appropriateplace for that logic.)
cc @codeclimate/review @maxjacobson