Skip to content
This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Conversation

@wfleming
Copy link
Contributor

@wfleming wfleming commented Aug 31, 2017

  • We incorrectly looked for debug at the root of config.json: a
    pre-release version of the CLI does do this right now, but the stable
    version should look under the config key, which is populated via the
    .codeclimate.yml.

  • The logger must be at debug level for dump_ast: updated the README
    to reflect that.

@wfleming wfleming requested a review from toddmazierski August 31, 2017 21:49
@wfleming wfleming force-pushed the will/sexp_dump_debug branch from 7a0ddb0 to 2252449 Compare August 31, 2017 22:01
- We incorrectly looked for `debug` at the root of `config.json`: a
  pre-release version of the CLI does do this right now, but the stable
  version should look under the `config` key, which is populated via the
  `.codeclimate.yml`.

- The logger must be at `debug` level for `dump_ast`: updated the README
  to reflect that.
@wfleming wfleming force-pushed the will/sexp_dump_debug branch from 2252449 to 25a566c Compare August 31, 2017 22:03
@wfleming wfleming changed the title Fix README for using dump_ast Fix debug handling & README instructions for dump_ast Aug 31, 2017
Copy link
Contributor

@toddmazierski toddmazierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@wfleming wfleming mentioned this pull request Aug 31, 2017
@wfleming wfleming merged commit 26f7f3e into master Aug 31, 2017
@wfleming wfleming deleted the will/sexp_dump_debug branch August 31, 2017 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants