From a4557bf52e27e7f52f43451542e91fa3ca78706e Mon Sep 17 00:00:00 2001 From: Max Jacobson Date: Fri, 18 Nov 2016 13:58:33 -0500 Subject: [PATCH] Shorten test coverage status Our messages are being truncated to, e.g. "58.02% test coverage (+1..." The status already has a name of "codeclimate/coverage", so I think with context this will be sufficient information. --- lib/cc/presenters/pull_requests_presenter.rb | 2 +- spec/cc/presenters/pull_requests_presenter_spec.rb | 6 +++--- spec/cc/service/github_pull_requests_spec.rb | 2 +- spec/cc/service/gitlab_merge_requests_spec.rb | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/cc/presenters/pull_requests_presenter.rb b/lib/cc/presenters/pull_requests_presenter.rb index 0ec13d4..ace79a1 100644 --- a/lib/cc/presenters/pull_requests_presenter.rb +++ b/lib/cc/presenters/pull_requests_presenter.rb @@ -28,7 +28,7 @@ def skipped_message end def coverage_message - message = "#{formatted_percent(@covered_percent)}% test coverage" + message = "#{formatted_percent(@covered_percent)}%" if @covered_percent_delta > 0 message += " (+#{formatted_percent(@covered_percent_delta)}%)" diff --git a/spec/cc/presenters/pull_requests_presenter_spec.rb b/spec/cc/presenters/pull_requests_presenter_spec.rb index 074211d..536cb0d 100644 --- a/spec/cc/presenters/pull_requests_presenter_spec.rb +++ b/spec/cc/presenters/pull_requests_presenter_spec.rb @@ -22,15 +22,15 @@ end it "message coverage same" do - expect("85% test coverage").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message) + expect("85%").to eq(build_presenter({}, "covered_percent" => 85, "covered_percent_delta" => 0).coverage_message) end it "message coverage up" do - expect("85.5% test coverage (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message) + expect("85.5% (+2.46%)").to eq(build_presenter({}, "covered_percent" => 85.5, "covered_percent_delta" => 2.4567).coverage_message) end it "message coverage down" do - expect("85.35% test coverage (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message) + expect("85.35% (-3%)").to eq( build_presenter({}, "covered_percent" => 85.348, "covered_percent_delta" => -3.0).coverage_message) end private diff --git a/spec/cc/service/github_pull_requests_spec.rb b/spec/cc/service/github_pull_requests_spec.rb index 27a6b42..19853e3 100644 --- a/spec/cc/service/github_pull_requests_spec.rb +++ b/spec/cc/service/github_pull_requests_spec.rb @@ -72,7 +72,7 @@ it "pull request coverage status" do expect_status_update("pbrisbin/foo", "abc123", "state" => "success", - "description" => "87% test coverage (+2%)") + "description" => "87% (+2%)") receive_pull_request_coverage({}, github_slug: "pbrisbin/foo", diff --git a/spec/cc/service/gitlab_merge_requests_spec.rb b/spec/cc/service/gitlab_merge_requests_spec.rb index 4d0b3a5..7d5b4bc 100644 --- a/spec/cc/service/gitlab_merge_requests_spec.rb +++ b/spec/cc/service/gitlab_merge_requests_spec.rb @@ -102,7 +102,7 @@ "hal/hal9000", "abc123", "state" => "success", - "description" => "87% test coverage (+2%)", + "description" => "87% (+2%)", ) receive_merge_request_coverage(