Simplify exclude_paths generated by init #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfleming
force-pushed
the
will/init-excludes
branch
from
71c0b3d
to
a26800a
Compare
|
Did you mean to type |
Sigh. That is what I typed, but markdown decided that meant I wanted "*/". Fixed above. |
| path | ||
| end | ||
| end | ||
| config["exclude_paths"] += paths |
There was a problem hiding this comment.
Could be a good use case for |= here
There was a problem hiding this comment.
Good point. Updated.
Previously we appended "**/*" to all auto-excluded directories: that's no longer required by the new exclude behavior, so no reason to keep it.
wfleming
force-pushed
the
will/init-excludes
branch
from
a26800a
to
319538a
Compare
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Feb 1, 2016
Simplify exclude_paths generated by init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we appended
**/*to all auto-excluded directories: that'sno longer required by the new exclude behavior, so no reason to keep it.
cc @codeclimate/review