From f6f5baf390f8e805db2c46bc7eaa423ca10a3744 Mon Sep 17 00:00:00 2001 From: Devon Blandin Date: Tue, 14 Mar 2017 22:10:22 -0400 Subject: [PATCH 1/3] Require `LABEL maintainer` instead of `MAINTAINER` (deprecated) Before: ``` MAINTAINER "Your Name" ``` After: ``` LABEL maintainer "Your Name " ``` --- SPEC.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SPEC.md b/SPEC.md index 291ddb2..5a379a6 100644 --- a/SPEC.md +++ b/SPEC.md @@ -313,7 +313,7 @@ easily portable between systems, regardless of the programming language they are implemented in. We recommend Engine implementors use a `Dockerfile` to automate the builds of these images. The `Dockerfile` must follow these specifications: -* The images must specify a `MAINTAINER`. +* The image must specify a `maintainer` `LABEL`: * The `/code` must be declared as a `VOLUME`. * The `WORKDIR` must be specified as `/code` * A non-root user named `app` must be created with UID and GID 9000 and declared From 4855ee2bb844adb94f3b2e8b7d431780cf8fbff0 Mon Sep 17 00:00:00 2001 From: Devon Blandin Date: Tue, 14 Mar 2017 22:12:09 -0400 Subject: [PATCH 2/3] Update Dockerfile example - Explicit image tag - Alpine image - `maintainer` LABEL - Caching of dependencies --- SPEC.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/SPEC.md b/SPEC.md index 5a379a6..e95387d 100644 --- a/SPEC.md +++ b/SPEC.md @@ -325,21 +325,25 @@ the builds of these images. The `Dockerfile` must follow these specifications: Here is an example of a `Dockerfile` that follows the specifications for an engine written in Node.js: ``` -FROM node +FROM node:7.7-alpine -MAINTAINER Michael R. Bernstein +LABEL maintainer "Your Name " -RUN useradd -u 9000 -r -s /bin/false app +WORKDIR /usr/src/app +COPY package.json /usr/src/app/ -RUN npm install glob +RUN npm install -WORKDIR /code +RUN adduser -u 9000 -D app COPY . /usr/src/app +RUN chown -R app:app /usr/src/app USER app + VOLUME /code +WORKDIR /code -CMD ["/usr/src/app/bin/fixme"] +CMD ["/usr/src/app/bin/your-engine"] ``` ## Naming convention From 7a0b59a93bee07ee83851b533f0904aef2d9174c Mon Sep 17 00:00:00 2001 From: Devon Blandin Date: Wed, 15 Mar 2017 11:11:53 -0400 Subject: [PATCH 3/3] Bump spec version to v0.3.1 --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index 0d91a54..9e11b32 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.3.0 +0.3.1