New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sum-coverage #31

Closed
pbrisbin opened this Issue Mar 17, 2017 · 10 comments

Comments

Projects
None yet
3 participants
@pbrisbin
Copy link
Contributor

pbrisbin commented Mar 17, 2017

When I've generated multiple payloads from multiple (partial) test-suite runs, I want to combine (sum) them into a single payload, so I can upload it to Code Climate.

Acceptance Criteria

We've used this in our parallel test builds for codeclimate/app and the summed coverage is reported and accurate.

@pbrisbin pbrisbin added this to the Alpha milestone Mar 17, 2017

@markbates markbates closed this in 4cabfc9 Mar 17, 2017

@pbrisbin pbrisbin reopened this Mar 17, 2017

@pbrisbin

This comment has been minimized.

Copy link
Contributor Author

pbrisbin commented Mar 17, 2017

Shouldn't have auto-closed ;)

@pbrisbin pbrisbin assigned ale7714 and unassigned markbates, ale7714 and pbrisbin Mar 17, 2017

@ale7714

This comment has been minimized.

Copy link
Member

ale7714 commented Mar 22, 2017

I created two test reports for our app repo and got some discrepancies in coverage percent. Line/file count looks correct.

test-reporter:
screen shot 2017-03-21 at 10 49 39 pm

Payloads: Archive.zip

ruby-test-reporter:

screen shot 2017-03-21 at 10 49 45 pm

To confirm simple cov returns same result as ruby-test-reporter
screen shot 2017-03-21 at 8 44 30 pm

Also here's the resultset for app resultset.json.zip

@pbrisbin

This comment has been minimized.

Copy link
Contributor Author

pbrisbin commented Mar 22, 2017

@ale7714

This comment has been minimized.

Copy link
Member

ale7714 commented Mar 22, 2017

Here are the individual-resultset.zip from the CI run

@markbates let me know if you need any more info :)

@markbates

This comment has been minimized.

Copy link
Contributor

markbates commented Mar 22, 2017

Thanks. That's really useful. I'll be digging into this this afternoon.

@markbates markbates assigned markbates and unassigned ale7714 Mar 22, 2017

@markbates

This comment has been minimized.

Copy link
Contributor

markbates commented Mar 22, 2017

@ale7714 Can you send me a screenshot of the HTML page that gets generated? Or a CSV that has the following information for both the whole project and a couple of the individual files. I'm trying to figure why my math isn't lining up with theirs. Looking at the Simple Cov source code it should.

Total Lines, Total Lines Covered, Total Lines Missed, Covered Percent

@ale7714

This comment has been minimized.

Copy link
Member

ale7714 commented Mar 22, 2017

@markbates sure, will send you a zip with the html so you have all the information.

@ale7714

This comment has been minimized.

Copy link
Member

ale7714 commented Mar 22, 2017

@markbates hope the zip is helpful coverage.zip.

@markbates

This comment has been minimized.

Copy link
Contributor

markbates commented Mar 22, 2017

thanks!

@ale7714

This comment has been minimized.

Copy link
Member

ale7714 commented Mar 22, 2017

After fixes covered percentage is correct.

@ale7714 ale7714 closed this Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment