China contact us page& base-flat footer update #5771
Conversation
wjllance
commented
Feb 25, 2020
wjllance
commented
|
Removed several unused variable |
| @@ -564,6 +564,7 @@ body[lang='ru'], body[lang='uk'], body[lang='bg'], body[lang^='mk'], body[lang=' | |||
| letter-spacing: 0.48px | |||
| line-height: 30px | |||
| margin: 20px auto | |||
| display: block | |||
There was a problem hiding this comment.
I think h3 should have display set to block by default on browsers. Interested why we're adding the explicit display and if this could cause style regressions?
Thanks! I like explicit styles so happy with this change, just clarifying what issue prompted this addition.
There was a problem hiding this comment.
It's overwrote in this page, so have to add the explicit style
There was a problem hiding this comment.
Small question/clarification regarding a style addition.
Otherwise I tested manually and compared the footer and header with production.
Also tested with feature.china set to true and it looks great!
Small nitpick on the image in the contact china team page. That jpeg loading could be changed to progressive jpeg loading. But it's an optimization and not critical.
Amazing stuff!
progressive jpeg is really a great tool! |
