Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Passthrough of Bash Uploader Arguments #156

Closed
wants to merge 6 commits into from
Closed

Implement Passthrough of Bash Uploader Arguments #156

wants to merge 6 commits into from

Conversation

kennethtran93
Copy link

@kennethtran93 kennethtran93 commented Oct 23, 2020

This should allow users to use arguments that can be used in the bash uploader.
Should resolve #73, resolve #76, resolve #92. May resolve #155 by yours truly by usage of -P argument

This also slightly optimized the truthy check in fail_ci.

Checks if name and flags inputs are used first before adding it into the bash arguments. This eliminates the empty -n and -F flags. Unsure if they were there on purpose though.

As well as minor rewording in the README in the Arguments section.

Couple of things to note:

  • Bash args are one per line. Pipe should be used if more than one bash arg needed.
  • Based on your current args, I have it set to extract the first two characters for the arg, and the rest as the value of the arg.
  • This doesn't check if the arg itself is valid. It simply passes it through to the bash script.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           2        2           
  Lines          16       16           
  Branches        2        2           
=======================================
  Hits           14       14           
  Misses          2        2           
Flag Coverage Δ
#unittest 87.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5dfa5...1d8f045. Read the comment docs.

@thomasrockhu
Copy link
Contributor

@kennethtran93, is this still relevant? We have ported over the bash uploader args

@petrsvihlik
Copy link

petrsvihlik commented Feb 28, 2021

@thomasrockhu Well, the problem described in #155 is still relevant.

@thomasrockhu
Copy link
Contributor

@petrsvihlik I believe you are not using fetch-depth: 2 for this, but the initial intent of this PR has been corrected by providing the same properties as the bash uploader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants