Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add override OS and linux default to platform #485

Merged
merged 4 commits into from Aug 24, 2021

Conversation

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Aug 20, 2021

fixes #471

Allows for users to set an OS to override detection. Also selects linux as the default

@thomasrockhu-codecov thomasrockhu-codecov requested a review from Aug 20, 2021
@codecov
Copy link

@codecov codecov bot commented Aug 20, 2021

Codecov Report

Merging #485 (6feb914) into master (17debce) will decrease coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   96.46%   95.91%   -0.55%     
==========================================
  Files           3        4       +1     
  Lines         113      147      +34     
  Branches       34       40       +6     
==========================================
+ Hits          109      141      +32     
- Misses          4        6       +2     
Flag Coverage Δ
demo 85.71% <ø> (ø)
macos-latest 95.91% <100.00%> (-0.55%) ⬇️
script 96.99% <100.00%> (-0.99%) ⬇️
ubuntu-latest 95.91% <100.00%> (-0.55%) ⬇️
windows-latest 95.91% <100.00%> (-0.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 99.00% <100.00%> (+1.02%) ⬆️
src/helpers.ts 90.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17debce...6feb914. Read the comment docs.

@thomasrockhu-codecov thomasrockhu-codecov merged commit 5a8bb47 into master Aug 24, 2021
13 of 14 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the alternate-os branch Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants