Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions support #160

Merged
merged 12 commits into from Sep 16, 2020
Merged

Conversation

ibrahim0814
Copy link
Contributor

@ibrahim0814 ibrahim0814 commented Nov 13, 2019

Purpose

Currently there's no way for the node uploader to detect Actions CI/CD pipelines. This PR adds support for it.

Note: There's currently no way to obtain a build_url or build number from the Actions environment variables. That's why they've been excluded in this PR.

@ibrahim0814
Copy link
Contributor Author

ibrahim0814 commented Nov 13, 2019

@eddiemoore Do you know why these tests are failing? I can't really tell why from the output on Travis

test/services/github_actions.test.js Outdated Show resolved Hide resolved
test/services/github_actions.test.js Outdated Show resolved Hide resolved
@eddiemoore
Copy link
Collaborator

eddiemoore commented Jan 31, 2020

Sorry it's taken me so long to review this because of my current work.

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #160 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   83.78%   84.25%   +0.46%     
==========================================
  Files          22       23       +1     
  Lines         370      381      +11     
  Branches       92       95       +3     
==========================================
+ Hits          310      321      +11     
  Misses         49       49              
  Partials       11       11              
Impacted Files Coverage Δ
lib/detect.js 92.30% <ø> (ø)
lib/services/github_actions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2d353...3bc49d4. Read the comment docs.

@ibrahim0814
Copy link
Contributor Author

ibrahim0814 commented Jan 31, 2020

@eddiemoore No worries! Fixed the jest assertions and Travis is now passing.

@ibrahim0814 ibrahim0814 requested a review from eddiemoore Jan 31, 2020
lib/services/github_actions.js Outdated Show resolved Hide resolved
test/services/github_actions.test.js Outdated Show resolved Hide resolved
@ibrahim0814
Copy link
Contributor Author

ibrahim0814 commented Feb 1, 2020

Corrected the service name!

@ibrahim0814 ibrahim0814 requested a review from eddiemoore Feb 1, 2020
@JustinBeckwith
Copy link
Contributor

JustinBeckwith commented Mar 6, 2020

Greetings folks! This is a change that would make our lives much easier :) Anything I can do to help it get merged?

@ibrahim0814 ibrahim0814 closed this Mar 6, 2020
@ibrahim0814 ibrahim0814 reopened this Mar 6, 2020
@ibrahim0814
Copy link
Contributor Author

ibrahim0814 commented Mar 6, 2020

Accidentally closed this PR, sorry about that. @eddiemoore, is this ready to merge?

kincaidoneil added a commit to interledgerjs/interledgerjs that referenced this pull request May 19, 2020
- codecov npm module doesn't support GitHub Actions/correctly report branches: codecov/codecov-node#160
- switch to codecov bash uploader
@thomasrockhu thomasrockhu self-requested a review Aug 24, 2020
@thomasrockhu thomasrockhu reopened this Sep 8, 2020
@thomasrockhu thomasrockhu merged commit 33300b5 into codecov:master Sep 16, 2020
7 checks passed
@thomasrockhu
Copy link
Contributor

thomasrockhu commented Sep 16, 2020

As always, thanks @ibrahim0814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants