Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken gcov command #173

Merged
merged 1 commit into from Sep 9, 2020
Merged

Fix broken gcov command #173

merged 1 commit into from Sep 9, 2020

Conversation

ptomato
Copy link
Contributor

@ptomato ptomato commented Mar 6, 2020

The gcov command can't be generated if none of the gcov options are
given on the command line, since sanitizeVar() will throw an exception
when given 'undefined' as input. This runs sanitizeVar only if the
options are actually given.

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #173 into master will decrease coverage by 6.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   90.16%   83.78%   -6.39%     
==========================================
  Files          23       22       -1     
  Lines         356      370      +14     
  Branches       85       92       +7     
==========================================
- Hits          321      310      -11     
- Misses         35       49      +14     
- Partials        0       11      +11     
Impacted Files Coverage Δ
lib/codecov.js 70.93% <0.00%> (-11.08%) ⬇️
lib/services/codebuild.js 100.00% <0.00%> (ø)
lib/offline.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe132e...764a681. Read the comment docs.

@ptomato
Copy link
Contributor Author

ptomato commented Aug 5, 2020

Ping?

Copy link
Contributor

@thomasrockhu thomasrockhu left a comment

👏 @ptomato thanks for this PR! However, I actually think it makes more sense to patch sanitizeVar to accept undefined here, as these are the only instances that use it. Would you mind making that change instead unless you disagree?

@ptomato
Copy link
Contributor Author

ptomato commented Sep 9, 2020

Sure, updated, thanks for the review! Do note that I forgot what I was trying to do 6 months ago that was broken, so I wasn't able to test that it fixed my particular use case this time. It seems like this approach ought to have the same effect, though.

The gcov command can't be generated if none of the gcov options are
given on the command line, since sanitizeVar() will throw an exception
when given 'undefined' as input. This allows sanitizeVar() to accept an
input of 'undefined'.
@thomasrockhu thomasrockhu merged commit e737099 into codecov:master Sep 9, 2020
2 of 4 checks passed
@ptomato ptomato deleted the fix-gcov-command branch Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants