Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CHANGELOG and remove flaky v4 test #204

Merged
merged 1 commit into from Aug 21, 2020
Merged

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Aug 20, 2020

No description provided.

@thomasrockhu thomasrockhu requested a review from drazisil Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #204 into master will decrease coverage by 4.95%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   88.64%   83.69%   -4.96%     
==========================================
  Files          23       22       -1     
  Lines         370      368       -2     
  Branches       91       91              
==========================================
- Hits          328      308      -20     
- Misses         34       49      +15     
- Partials        8       11       +3     
Impacted Files Coverage Δ
lib/codecov.js 70.64% <50.00%> (-8.96%) ⬇️
lib/offline.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd0a1a...dc09448. Read the comment docs.

@thomasrockhu
Copy link
Contributor Author

thomasrockhu commented Aug 20, 2020

It's fine, commented out some flaky tests

@thomasrockhu thomasrockhu merged commit bdf23bd into master Aug 21, 2020
5 of 7 checks passed
@thomasrockhu thomasrockhu deleted the remove-flaky-v4 branch Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants