Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errant bitly #220

Merged
merged 1 commit into from Sep 21, 2020
Merged

Remove errant bitly #220

merged 1 commit into from Sep 21, 2020

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Sep 20, 2020

fixes #128

Steve added this 5 years ago, I have no idea what it's supposed to actually point to now.

@thomasrockhu thomasrockhu requested review from drazisil-codecov and a team Sep 20, 2020
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files          23       23           
  Lines         381      381           
  Branches       95       95           
=======================================
  Hits          321      321           
  Misses         49       49           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33300b5...42ef987. Read the comment docs.

@thomasrockhu thomasrockhu merged commit bcd0ad7 into master Sep 21, 2020
12 checks passed
@thomasrockhu thomasrockhu deleted the remove-errant-bitly branch Sep 21, 2020
@drazisil-codecov
Copy link
Contributor

drazisil-codecov commented Sep 21, 2020

Looks like the same way as we do now. https://travis-ci.org/github/pyca/cryptography/jobs/75080600#L443

I like the inline example better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codecov --env example link is broken
3 participants