Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage-final.json and bump to 3.8.2 #304

Merged
merged 1 commit into from May 3, 2021
Merged

Conversation

thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Apr 23, 2021

  • Add coverage-final.json to the list of possible coverage files
    This is already done in the bash uploader and is a result of this community post

  • Clean up the README

  • Alphabetize some of the patterns

@thomasrockhu thomasrockhu requested a review from a team Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #304 (a8bf57f) into master (d91e38f) will increase coverage by 1.27%.
The diff coverage is 50.00%.

Current head a8bf57f differs from pull request most recent head bd9a87a. Consider uploading reports for the commit bd9a87a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   82.19%   83.46%   +1.27%     
==========================================
  Files          23       23              
  Lines         292      381      +89     
  Branches       60       95      +35     
==========================================
+ Hits          240      318      +78     
- Misses         40       51      +11     
  Partials       12       12              
Impacted Files Coverage Δ
lib/codecov.js 70.93% <50.00%> (-1.42%) ⬇️
lib/git.js 100.00% <0.00%> (ø)
lib/services/snap.js 100.00% <0.00%> (ø)
lib/services/drone.js 100.00% <0.00%> (ø)
lib/services/circle.js 100.00% <0.00%> (ø)
lib/services/cirrus.js 100.00% <0.00%> (ø)
lib/services/gitlab.js 100.00% <0.00%> (ø)
lib/services/heroku.js 100.00% <0.00%> (ø)
lib/services/travis.js 100.00% <0.00%> (ø)
lib/services/jenkins.js 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91e38f...bd9a87a. Read the comment docs.

@thomasrockhu thomasrockhu marked this pull request as ready for review Apr 27, 2021
CHANGELOG.md Show resolved Hide resolved
@thomasrockhu thomasrockhu merged commit 19b47f2 into master May 3, 2021
10 of 11 checks passed
@thomasrockhu thomasrockhu deleted the coveragefinaljson branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants