Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

hg identify call fails because it uses a |, but try_to_run() is missing shell=True #284

antonv6 opened this issue Jul 4, 2020 · 0 comments · Fixed by #298


Copy link

antonv6 commented Jul 4, 2020

Noticed by browsing somebody else's CI output:

 hg identify: option -d not recognized

But, as you can see in this file: the command's intent is to provide -d not to hg id, but to tr. It doesn't work because by default shell argument of try_to_run() is False.

The fix could be to just provide shell=True to that function, but I suggest to replace the whole call with try_to_run(['hg', 'log', '-r', '.', '-T', '{node}']).

Thank you for supporting Mercurial. If you have any questions, feel free to ping me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging a pull request may close this issue.

1 participant