Skip to content
This repository was archived by the owner on Oct 24, 2023. It is now read-only.

Conversation

@tjkandala
Copy link
Contributor

@tjkandala tjkandala commented Apr 29, 2021

Use the new Status Bar API to show file coverage ratios and link to commit reports. As a result, the Codecov extension now supports the Sourcegraph commit page.

Notes:

  • Debounce setStatusBars and updateContext calls to prevent doing unnecessary work on diff views.
  • I initially tried factoring out API calls shared between setStatusBars and updateContext, but I decided against it since the result is memoized anyways.

TODO:

Has been published to sourcegraph.com for testing

@tjkandala tjkandala requested a review from felixfbecker April 30, 2021 00:13
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #68 (d79004a) into master (b29c80c) will decrease coverage by 0.71%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #68      +/-   ##
=========================================
- Coverage    9.78%   9.06%   -0.72%     
=========================================
  Files           8       8              
  Lines         378     408      +30     
  Branches       99     107       +8     
=========================================
  Hits           37      37              
- Misses        341     371      +30     
Impacted Files Coverage Δ
src/extension.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29c80c...d79004a. Read the comment docs.

@muratsu muratsu merged commit be8362a into master May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants