Skip to content

feat: add customer support PIN for owner identity verification#1026

Merged
thomasrockhu-codecov merged 2 commits into
mainfrom
th/support-pin
Jun 8, 2026
Merged

feat: add customer support PIN for owner identity verification#1026
thomasrockhu-codecov merged 2 commits into
mainfrom
th/support-pin

Conversation

@thomasrockhu-codecov

@thomasrockhu-codecov thomasrockhu-codecov commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a randomly generated 6-digit support_pin to each Owner (shared model) so customers can verify their identity to a support agent.
  • New migration 0075_owner_support_pin adds the field and backfills a distinct random PIN per existing owner.
  • Add regenerateSupportPin GraphQL mutation (current owner) and expose supportPin on the Me type for display.
  • Django admin: show support_pin in the Owner list view and add a staff-gated "Regenerate support PIN" action.
image image

Test plan

  • RegenerateSupportPinInteractor tests (unauthenticated rejected; PIN regenerated, 6-digit, numeric, changed)
  • regenerateSupportPin GraphQL mutation tests (unauthenticated + authenticated)
  • OwnerAdmin tests (regenerate action across multiple owners, staff-only availability)
  • Run migration 0075 and confirm existing owners receive distinct PINs

Note: the matching frontend (Gazebo) changes are in a separate PR.

Made with Cursor

Add a randomly generated 6-digit support PIN to each Owner that customers
provide to a support agent to verify their identity.

- New support_pin field on Owner (shared) with migration 0075 that backfills
  a distinct random PIN per existing owner
- regenerateSupportPin GraphQL mutation (current owner) and supportPin exposed
  on the Me type for display
- Django admin: support_pin in the Owner list view plus a staff-gated
  "Regenerate support PIN" action
@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team as a code owner June 6, 2026 03:34
@codspeed-hq

codspeed-hq Bot commented Jun 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks


Comparing th/support-pin (1daee65) with main (2d9b8de)

Open in CodSpeed

@codecov-notifications

codecov-notifications Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sentry

sentry Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (2d9b8de) to head (1daee65).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   91.89%   91.90%   +0.01%     
==========================================
  Files        1318     1322       +4     
  Lines       50724    50790      +66     
  Branches     1625     1625              
==========================================
+ Hits        46612    46678      +66     
  Misses       3806     3806              
  Partials      306      306              
Flag Coverage Δ
apiunit 94.95% <100.00%> (+0.01%) ⬆️
sharedintegration 36.92% <21.42%> (-0.02%) ⬇️
sharedunit 84.92% <100.00%> (+0.01%) ⬆️
workerintegration 58.56% <ø> (ø)
workerunit 90.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Jun 8, 2026
@thomasrockhu-codecov thomasrockhu-codecov removed this pull request from the merge queue due to a manual request Jun 8, 2026
# Conflicts:
#	apps/codecov-api/codecov_auth/admin.py
@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 9c18730 Jun 8, 2026
50 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/support-pin branch June 8, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants