Custom defined name of the upload #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drazisil-codecov
approved these changes
May 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
- Coverage 86.38% 80.45% -5.93%
==========================================
Files 6 7 +1
Lines 191 261 +70
Branches 26 44 +18
==========================================
+ Hits 165 210 +45
- Misses 19 35 +16
- Partials 7 16 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@drazisil-codecov VSCode picks up on them without the jsconfig.js. It uses the inbuilt typescript engine to handle the comments |
eddiemoore
added a commit
to eddiemoore/uploader
that referenced
this pull request
May 5, 2021
…ironment-variables * 'master' of github.com:codecov/uploader: Custom defined name of the upload (codecov#75)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding name flag as defined in the upload API https://docs.codecov.io/reference#upload
Removed
expectas it is not needed as jest has it built in.Added JSDoc comments to some functions.
Adding coverage to index.js file