Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EBS config parameter for using larger device ranges #996

Merged
merged 1 commit into from Sep 6, 2017

Conversation

thevilledev
Copy link
Contributor

This proposed change has been previously discussed on these issues:

I've now rebased the libstorage-specific change to the current REX-Ray master, since libstorage will be merged into this project. This change is targeted to the next REX-Ray version, which will be 0.10. Large device range has been introduced as a EBS configuration parameter useLargeDeviceRange which is false by default.

In order to workaround possible ghost device issues the device namespace is now iterated in a random order. This affects default behaviour as well.

In order to test this change both server and client-side re-configuration is required. Server configuration (in terms of EBS) should look like this:

ebs:
  accessKey:      foo
  secretKey:      bar
  region:         us-east-1
  maxRetries: 10
  statusTimeout: 240s
  statusInitialDelay: 50ms
  statusMaxAttempts: 10
  useLargeDeviceRange: true

Client configuration:

ebs:
  useLargeDeviceRange: true

Pre-built binary for amd64 architecture is available here: https://github.com/vtorhonen/rexray/releases/tag/v0.10.0-lds

Let me know if there's anything to fix/add.

This patch adds a new configuration parameter 'useLargeDeviceRange'
for EBS storage provider. This allows users to attach much
more EBS volumes per host. However, REX-Ray will still use the
AWS recommended device mapping by default.

In order to prevent ghost device issues with both 'default' and
'large' device ranges the device namespace is iterated in a
random order each time new device allocation occurs.

New configuration parameter added to docs as well.
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   34.11%   34.11%           
=======================================
  Files          36       36           
  Lines        2896     2896           
=======================================
  Hits          988      988           
  Misses       1806     1806           
  Partials      102      102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e95e6...ed91d56. Read the comment docs.

@akutz akutz self-requested a review September 6, 2017 15:58
Copy link
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. Great work @vtorhonen!

@akutz akutz merged commit e1e8cea into rexray:master Sep 6, 2017
@akutz akutz added this to the 2017.09-1 milestone Sep 6, 2017
@akutz akutz self-assigned this Sep 6, 2017
@akutz akutz added the ebs label Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants