Skip to content
This repository was archived by the owner on Sep 19, 2018. It is now read-only.

Add the ability to display past events on the map #252

Merged
merged 9 commits into from
Jun 11, 2014

Conversation

ialja
Copy link
Contributor

@ialja ialja commented Jun 10, 2014

Currently, the map can only show upcoming events. Added a simple link that enables the display of past events and removed some code that is no longer used in the index view.

ialja added 6 commits June 10, 2014 22:30
This parameter was used in the index view when we displayed cards for X latest events for each country. Now we just display events on the map, so this is no longer needed.
@@ -42,9 +42,13 @@
"""


def index(request, country_code=None):
def index(request, country_code=None, past='no'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably better to be boolean value, if I say 'yes' than this would be same if there wouldn't be any parsing. Besides, boolean value takes less resources than string :)

ercchy added a commit that referenced this pull request Jun 11, 2014
Add the ability to display past events on the map
@ercchy ercchy merged commit 3c646d9 into codeeu:master Jun 11, 2014
@ercchy
Copy link
Contributor

ercchy commented Jun 11, 2014

That will do cat, that wil do...

@ialja ialja deleted the past-events branch June 11, 2014 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants