Skip to content

⚡️ Speed up method Resources.components_for by 140% #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.9
Choose a base branch
from
Open

⚡️ Speed up method Resources.components_for by 140% #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/bokeh/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@
from __future__ import annotations

import logging # isort:skip
from bokeh.core.types import PathLike
from bokeh.settings import LogLevel, settings

log = logging.getLogger(__name__)

Expand Down Expand Up @@ -420,7 +422,12 @@ def root_url(self) -> str:
# Public methods ----------------------------------------------------------

def components_for(self, kind: Kind) -> list[Component]:
return [comp for comp in self.components if comp in self._component_defs[kind]]
# Use set intersection for faster filtering on large component lists
kind_comps = self._component_defs[kind]
if not kind_comps:
return []
kind_set = set(kind_comps)
return [comp for comp in self.components if comp in kind_set]

def _file_paths(self, kind: Kind) -> list[Path]:
minified = ".min" if self.minified else ""
Expand Down