From 3d833e269305d012b304c03b400202a05311571c Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Thu, 23 Oct 2025 06:49:45 +0000
Subject: [PATCH] Optimize AudioTranscriptionRequest.serialize_model

The optimized code achieves an **18% speedup** through several algorithmic and memory efficiency improvements:

**Key Optimizations:**

1. **O(1) membership testing**: Converted `optional_fields` and `nullable_fields` from lists to sets, eliminating O(n) list scans in favor of O(1) hash lookups during the `k in optional_fields` checks in the loop.

2. **Precomputed intersection**: Created `optional_nullable_fields = optional_fields_set & nullable_fields_set` outside the loop to avoid repeatedly computing `k in optional_fields and k in nullable_fields` for each field.

3. **Combined get/pop operation**: Replaced separate `serialized.get(k)` and `serialized.pop(k, None)` calls with a single `serialized.pop(k, None)`, reducing dictionary operations from 2 to 1 per iteration.

4. **Eliminated set allocation**: Changed `self.__pydantic_fields_set__.intersection({n})` to direct membership test `n in fields_set`, avoiding temporary set creation for each field check.

5. **Reduced attribute lookups**: Cached `self.__pydantic_fields_set__` and `type(self).model_fields` as local variables to avoid repeated attribute access.

**Performance Impact:**
The test results show consistent 11-23% improvements across various scenarios, with the best gains (20-23%) occurring in cases with multiple optional fields where the set-based lookups provide maximum benefit. The optimization is particularly effective for models with many fields, as evidenced by the `test_many_instances_serialization` showing 20.2% improvement when processing 100 instances.
---
 .../models/audiotranscriptionrequest.py       | 34 ++++++++++++-------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/src/mistralai/models/audiotranscriptionrequest.py b/src/mistralai/models/audiotranscriptionrequest.py
index 371d3ecc..52fc3938 100644
--- a/src/mistralai/models/audiotranscriptionrequest.py
+++ b/src/mistralai/models/audiotranscriptionrequest.py
@@ -60,7 +60,8 @@ class AudioTranscriptionRequest(BaseModel):
 
     @model_serializer(mode="wrap")
     def serialize_model(self, handler):
-        optional_fields = [
+        # Constants for fast lookup: convert lists to sets for O(1) membership testing
+        optional_fields_set = {
             "file",
             "file_url",
             "file_id",
@@ -68,29 +69,36 @@ def serialize_model(self, handler):
             "temperature",
             "stream",
             "timestamp_granularities",
-        ]
-        nullable_fields = ["file_url", "file_id", "language", "temperature"]
-        null_default_fields = []
+        }
+        nullable_fields_set = {"file_url", "file_id", "language", "temperature"}
+        null_default_fields_set = set()  # remains empty as in original
 
         serialized = handler(self)
 
         m = {}
 
-        for n, f in type(self).model_fields.items():
+        fields_set = self.__pydantic_fields_set__  # pylint: disable=no-member
+        model_fields = type(self).model_fields
+
+        # Avoid repeated lookups and allocation in loop: precompute which fields are both optional and nullable
+        optional_nullable_fields = optional_fields_set & nullable_fields_set
+
+        # Use .items() directly; avoid repeated get/pop calls by saving alias lookup
+        for n, f in model_fields.items():
             k = f.alias or n
-            val = serialized.get(k)
-            serialized.pop(k, None)
+            val = serialized.pop(
+                k, None
+            )  # Do pop right away; also covers .get(k) usage
+
+            optional_nullable = k in optional_nullable_fields
 
-            optional_nullable = k in optional_fields and k in nullable_fields
-            is_set = (
-                self.__pydantic_fields_set__.intersection({n})
-                or k in null_default_fields
-            )  # pylint: disable=no-member
+            # Use set intersection boolean directly, no need to allocate intermediate set object
+            is_set = (n in fields_set) or (k in null_default_fields_set)
 
             if val is not None and val != UNSET_SENTINEL:
                 m[k] = val
             elif val != UNSET_SENTINEL and (
-                not k in optional_fields or (optional_nullable and is_set)
+                k not in optional_fields_set or (optional_nullable and is_set)
             ):
                 m[k] = val