Skip to content

⚡️ Speed up function validate_decimal by 35% #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function validate_decimal by 35% #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/mistralai/utils/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

from ..types.basemodel import BaseModel, Nullable, OptionalNullable, Unset

_DECIMAL_UNSET_TYPES = (Decimal, Unset)

_STR_INT_FLOAT_TYPES = (str, int, float)


def serialize_decimal(as_str: bool):
def serialize(d):
Expand All @@ -35,13 +39,21 @@ def validate_decimal(d):
if d is None:
return None

if isinstance(d, (Decimal, Unset)):
# Compare type directly for Decimal (bypasses isinstance overhead, but leaves Unset for legacy behavior)
if type(d) is Decimal or type(d) is Unset:
return d

# Only check for most common types first (fast-path), then do the expensive isinstance otherwise
if type(d) in _STR_INT_FLOAT_TYPES:
return Decimal(str(d))

if isinstance(d, _DECIMAL_UNSET_TYPES):
return d

if not isinstance(d, (str, int, float)):
raise ValueError("Expected string, int or float")
if isinstance(d, _STR_INT_FLOAT_TYPES):
return Decimal(str(d))

return Decimal(str(d))
raise ValueError("Expected string, int or float")


def serialize_float(as_str: bool):
Expand Down Expand Up @@ -178,7 +190,7 @@ def is_nullable(field):
if origin is Nullable or origin is OptionalNullable:
return True

if not origin is Union or type(None) not in get_args(field):
if origin is not Union or type(None) not in get_args(field):
return False

for arg in get_args(field):
Expand Down