Skip to content

⚡️ Speed up method SyncCursorPage.next_page_info by 933% #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SyncCursorPage.next_page_info by 933% #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/openai/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,9 @@ def next_page_info(self) -> Optional[PageInfo]:
if not data:
return None

item = cast(Any, data[-1])
if not isinstance(item, CursorPageItem) or item.id is None:
# Directly access last item for efficiency, and reduce casting overhead
item = data[-1]
if not hasattr(item, "id") or getattr(item, "id", None) is None:
# TODO emit warning log
return None

Expand Down