Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up472 search for project #473
Conversation
NealHumphrey
added some commits
Aug 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Approving my own PR in the interest of getting our code base caught up |
NealHumphrey
merged commit dbad4e9
into
dev
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
NealHumphrey commentedAug 18, 2017
Adds a searchbar to the top navigation, and adds two filter categories of project name and project address to the left sidebar. The searchbar uses a combined name/address field called 'proj_name_addre' which has been added to the API for the /filter and /projects endpoints. This has already been deployed to the live API so that this functionality can be tested w/out spinning up a local api server and swapping urls.
The search bar is a re-styled combo search/dropdown box, the same one we use for categorical data choices, and behaves like a regular filter control - this seemed like the fastest way to get a basic search functionality integrated into our current workflow. One downside is that it doesn't produce true 'search results' like a user might expect, rather it provides instant filtered results in the dropdown menu.
Currently this simply applies the filter the way a regular filter works, i.e. highlighting the project on the map. However, we could attach another event to the searchbar selection that takes them to the project view associated with the one matching project. Not sure which behaviour users would find more intuitive. At a minimum, we could activate the 'matching projects' tab, since the 'summary' tab does not make much sense when only one building is selected.
Should be ready to merge. Note the encoding/decoding on the url is working, though there seems to be a bug in all url decoding that causes it to fail to color code the dots sometimes.