New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

472 search for project #473

Merged
merged 4 commits into from Aug 24, 2017

Conversation

Projects
None yet
1 participant
@NealHumphrey
Copy link
Collaborator

NealHumphrey commented Aug 18, 2017

Adds a searchbar to the top navigation, and adds two filter categories of project name and project address to the left sidebar. The searchbar uses a combined name/address field called 'proj_name_addre' which has been added to the API for the /filter and /projects endpoints. This has already been deployed to the live API so that this functionality can be tested w/out spinning up a local api server and swapping urls.

The search bar is a re-styled combo search/dropdown box, the same one we use for categorical data choices, and behaves like a regular filter control - this seemed like the fastest way to get a basic search functionality integrated into our current workflow. One downside is that it doesn't produce true 'search results' like a user might expect, rather it provides instant filtered results in the dropdown menu.

Currently this simply applies the filter the way a regular filter works, i.e. highlighting the project on the map. However, we could attach another event to the searchbar selection that takes them to the project view associated with the one matching project. Not sure which behaviour users would find more intuitive. At a minimum, we could activate the 'matching projects' tab, since the 'summary' tab does not make much sense when only one building is selected.

Should be ready to merge. Note the encoding/decoding on the url is working, though there seems to be a bug in all url decoding that causes it to fail to color code the dots sometimes.

NealHumphrey added some commits Aug 18, 2017

Working search bar and project_addre search filter.
TODO url encoding needs to handle 'search' type of filter
- API now produces proj_name_addre for the filter and project endpoin…
…ts - allows the searchbar to use the combined field

- Router now correctly encodes the searchbar (need to debug decoding)
Decoding state from searchbar works (but another bug still exists - c…
…olor coding buildings from decoded state broken globally)
@NealHumphrey

This comment has been minimized.

Copy link
Collaborator Author

NealHumphrey commented Aug 24, 2017

Approving my own PR in the interest of getting our code base caught up

@NealHumphrey NealHumphrey merged commit dbad4e9 into dev Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment