Skip to content

Conversation

@sebCIL
Copy link
Contributor

@sebCIL sebCIL commented Mar 1, 2023

Changes

Display 'Subroutine' keyword in full-free.
image

image

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in the README
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam self-assigned this Mar 1, 2023
Copy link
Member

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but I don't believe it should be added in parser.js.

Instead, you should just append the keyword when looping though .subroutines in the language providers.

Here for example: https://github.com/halcyon-tech/vscode-rpgle/blob/6a7914c5497660f8eeb25cfee7c3583d8bcef49c/server/src/providers/documentSymbols.ts#L53

@sebCIL
Copy link
Contributor Author

sebCIL commented Mar 20, 2023

In fixed format, the keyword is added in parser.js :
https://github.com/halcyon-tech/vscode-rpgle/blob/6a7914c5497660f8eeb25cfee7c3583d8bcef49c/server/src/language/parser.js#L946
So I do the same.

@worksofliam
Copy link
Member

@sebCIL Good point! Thanks!

@worksofliam worksofliam merged commit e89b88a into codefori:main Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants