Remove build errors due to missing log directory #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d41e6f1 ("Merge pull request codeforkansascity#43 from fredlawl/issue-42") addressed an issue where there was need to have error logging in the project. A bug was introduced such that the log directory did not exists when Django operations are ran via ssh-ing into the container. This problem also exists for people who perform operations without the Docker build process. Fix this by adding in a logs directory into the project root, and modify the Docker startup script to create the files/directories before Django build processes runs. Signed-off-by: Frederick Lawler <fred@fredlawl.com>
|
+1 |
kolkheang
reviewed
Nov 20, 2018
| @@ -0,0 +1,2 @@ | |||
| * | |||
| !.gitignore | |||
There was a problem hiding this comment.
Why is this .gitignore here instead of the main project directory? You can just include the logs/*?
kolkheang
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d41e6f1 ("Merge pull request #43 from fredlawl/issue-42") addressed
an issue where there was need to have error logging in the project. A
bug was introduced such that the log directory did not exists when Django
operations are ran via ssh-ing into the container. This problem also exists
for people who perform operations without the Docker build process.
Fix this by adding in a logs directory into the project
root, and modify the Docker startup script to create the files/directories
before Django build processes runs.
Signed-off-by: Frederick Lawler fred@fredlawl.com