Skip to content

Conversation

@oddwili
Copy link
Contributor

@oddwili oddwili commented Nov 18, 2024

This PR:

Resolves #693

Screenshots (if applicable):

Screen Shot 2024-11-18 at 12 24 25 PM

@andycwilliams
Copy link
Member

I can take a closer look at this later but for now just wanted to request fixing the tests. We'll need that before ultimately approving.

Thanks for your effort!

@oddwili
Copy link
Contributor Author

oddwili commented Nov 18, 2024

updated and added tests and ran prettier

Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the changes for the Outbox when building with this branch. This looks good to me. 👍

Copy link
Member

@andycwilliams andycwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oddwili oddwili merged commit 6b37f9a into Development Nov 20, 2024
3 checks passed
@oddwili oddwili deleted the 693/update-outbox-recipient-text branch November 20, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] - Replace "Sender" with "Recipient" in Outbox

4 participants