Skip to content

Conversation

@omarNaifer12
Copy link
Contributor

This PR:

Resolves #694
1.
2. If needed, delete if not
3. If needed, delete if not

Screenshots (if applicable):

Add any screenshots/videos here.
screenShotNotification

Additional Context (optional):

Add any other context about the PR here.
I added a try-catch block to the handleShowDocumentLocal function in the DocumentTable component to handle the case where a user doesn't have access to a document. If a 403 error occurs (Unauthorized), the catch block triggers a notification informing the user they don't have permission to view the document.

@Jared-Krajewski @timbot1789 @xscottxbrownx @leekahung

Please review the changes and let me know if there are any adjustments or improvements needed.

Future Steps/PRs Needed to Finish This Work (optional):

Add any other steps/PRs that may be needed to continue this work if this PR is just a step in the right direction.

Issues needing discussion/feedback (optional):

1.
2. If needed, delete if not
3. If needed, delete if not

@andycwilliams andycwilliams added the enhancement Enhancement of existing features label Nov 24, 2024
@andycwilliams
Copy link
Member

This is working so far from my testing. However, I hesitate approving it just yet because it involves interaction with Solid and I have less experience on that aspect of the app. I'd like to wait for input from the development side and then can approve.

Thank you for your efforts!

@omarNaifer12
Copy link
Contributor Author

@andycwilliams Thank you for your review! I’ll wait for the approval.

Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good try catch. Can approve for merging 👍

@omarNaifer12
Copy link
Contributor Author

@leekahung Yes, thank you. I was trying to find a way to do this without it since it's not used much in the project, but I couldn't find one because it gives an error and needs to be addressed.

@omarNaifer12 omarNaifer12 merged commit 9e11756 into codeforpdx:Development Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] - Add notification for inaccessible data

3 participants