Skip to content

Conversation

@noam-codefresh
Copy link

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
Signed-off-by: Noam Gal <noam.gal@codefresh.io>
@noam-codefresh noam-codefresh marked this pull request as ready for review February 8, 2022 08:38
@noam-codefresh noam-codefresh merged commit fa1c102 into release-3.2 Feb 8, 2022
@noam-codefresh noam-codefresh deleted the CR-8697 branch February 8, 2022 16:34
denis-codefresh pushed a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Denis <denis@codefresh.io>
denis-codefresh pushed a commit that referenced this pull request Dec 6, 2022
Signed-off-by: Denis <denis@codefresh.io>
dmaizel pushed a commit that referenced this pull request Dec 10, 2024
Signed-off-by: Denis <denis@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants