Skip to content

Conversation

@kim-codefresh
Copy link

@kim-codefresh kim-codefresh commented Dec 28, 2022

Fixes #TODO

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: kim-codefresh <kim.aharfi@codefresh.io>
Signed-off-by: kim-codefresh <kim.aharfi@codefresh.io>
@kim-codefresh kim-codefresh merged commit b041819 into release-3.4 Jan 3, 2023
@ATGardner ATGardner deleted the CR-15902 branch July 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants