Skip to content

Conversation

@denis-codefresh
Copy link
Collaborator

@denis-codefresh denis-codefresh commented Dec 6, 2021

Signed-off-by: Denis denis@codefresh.io

Since we need this feature right now and we still weren't able to contribute it to the main repo.
More details are in this PR: argoproj#7302

Signed-off-by: Denis <denis@codefresh.io>
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #76 (31fc885) into release-3.2 (97b8cda) will increase coverage by 0.03%.
The diff coverage is 64.86%.

❗ Current head 31fc885 differs from pull request most recent head e81c6e4. Consider uploading reports for the commit e81c6e4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.2      #76      +/-   ##
===============================================
+ Coverage        48.57%   48.60%   +0.03%     
===============================================
  Files              265      265              
  Lines            19230    19234       +4     
===============================================
+ Hits              9341     9349       +8     
+ Misses            8843     8834       -9     
- Partials          1046     1051       +5     
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 50.33% <ø> (ø)
workflow/sync/lock_name.go 58.53% <64.86%> (-2.58%) ⬇️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.88%) ⬇️
workflow/controller/operator.go 71.13% <0.00%> (-0.15%) ⬇️
pkg/apiclient/offline-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-server-opts.go 100.00% <0.00%> (ø)
...piclient/http1/workflow-template-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5790f...e81c6e4. Read the comment docs.

Signed-off-by: Denis <denis@codefresh.io>
Signed-off-by: Denis <denis@codefresh.io>
@denis-codefresh denis-codefresh merged commit 734c781 into release-3.2 Dec 7, 2021
@noam-codefresh noam-codefresh deleted the advanced-sync branch July 5, 2022 08:09
denis-codefresh added a commit that referenced this pull request Dec 2, 2022
Signed-off-by: Denis <denis@codefresh.io>
denis-codefresh added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Denis <denis@codefresh.io>
denis-codefresh added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Denis <denis@codefresh.io>
denis-codefresh added a commit that referenced this pull request Dec 5, 2022
Signed-off-by: Denis <denis@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants