From abd3c24661dda8c8feaae0ef73d5e53d8ea6ad68 Mon Sep 17 00:00:00 2001 From: pprevautel Date: Wed, 9 Aug 2023 11:37:58 +0200 Subject: [PATCH 1/3] fix: Add title for footer links that open in a new tab #153 --- src/Footer.tsx | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/Footer.tsx b/src/Footer.tsx index c7440592b..097e7fe48 100644 --- a/src/Footer.tsx +++ b/src/Footer.tsx @@ -332,6 +332,7 @@ export const Footer = memo( )} target="_blank" href={`https://${domain}`} + title={`${domain} - ouvre une nouvelle fenêtre`} > {domain} @@ -502,7 +503,11 @@ const { useTranslation, addFooterTranslations } = createComponentI18nApi({ "license mention": (p: { licenseUrl: string }) => ( <> Sauf mention contraire, tous les contenus de ce site sont sous{" "} - + licence etalab-2.0 @@ -524,7 +529,11 @@ addFooterTranslations({ "license mention": p => ( <> Unless stated otherwise, all content of this website is under the{" "} - + etalab-2.0 license From 51aaca93c5e5cd6f8fc6f4a2ecbd73780d432da4 Mon Sep 17 00:00:00 2001 From: pprevautel Date: Thu, 10 Aug 2023 08:09:13 +0200 Subject: [PATCH 2/3] =?UTF-8?q?fix:=20[ouvre=20une=20nouvelle=20fen=C3=AAt?= =?UTF-8?q?re]=20should=20be=20localized=20as=20well?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Footer.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Footer.tsx b/src/Footer.tsx index 097e7fe48..e3ec81312 100644 --- a/src/Footer.tsx +++ b/src/Footer.tsx @@ -512,7 +512,8 @@ const { useTranslation, addFooterTranslations } = createComponentI18nApi({ ), - "our partners": "Nos partenaires" + "our partners": "Nos partenaires", + "open new window": "ouvre une nouvelle fenêtre" /* spell-checker: enable */ } }); @@ -537,7 +538,8 @@ addFooterTranslations({ etalab-2.0 license - ) + ), + "open new window": "open new window" } }); From 3207b5fda3c380e6167fa9a72b55f97d76dbe9ab Mon Sep 17 00:00:00 2001 From: pprev94 Date: Thu, 10 Aug 2023 15:51:57 +0200 Subject: [PATCH 3/3] Update src/Footer.tsx Co-authored-by: Joseph Garrone Signed-off-by: pprev94 --- src/Footer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Footer.tsx b/src/Footer.tsx index e3ec81312..e01f7b617 100644 --- a/src/Footer.tsx +++ b/src/Footer.tsx @@ -332,7 +332,7 @@ export const Footer = memo( )} target="_blank" href={`https://${domain}`} - title={`${domain} - ouvre une nouvelle fenêtre`} + title={`${domain} - ${t("open new window")}`} > {domain}